[wpimath] ChassisSpeeds fromRelative and discretize methods made instance methods #7115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Overall, looks pretty good! I'm a little worried about the fact that method chaining isn't possible anymore, but given that from my (very very limited) experience most operations are done in an imperative programming manner, it's probably fine? I'd like to hear some other people weigh in on this.
wpimath/src/main/java/edu/wpi/first/math/kinematics/ChassisSpeeds.java
Outdated
Show resolved
Hide resolved
calcmogul
approved these changes
Oct 22, 2024
spacey-sooty
pushed a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar in approach to PR #7113
This should make using the discretize and fromRelative methods a little easier for teams to use. Note fromRelative was name changed to toRelative.