Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MathUtil.clamp() with Java 21 Math.clamp() #6982 #7106

Closed
wants to merge 2 commits into from
Closed

Replace MathUtil.clamp() with Java 21 Math.clamp() #6982 #7106

wants to merge 2 commits into from

Conversation

leongmichael
Copy link
Contributor

resolve #6982

@leongmichael leongmichael requested a review from a team as a code owner September 20, 2024 06:33
@calcmogul
Copy link
Member

#6982 was labeled as blocked because we haven't yet upgraded to Java 21. We'll likely be doing so for the 2026 season.

@calcmogul calcmogul added the state: blocked Something is blocking action. label Sep 20, 2024
@KangarooKoala
Copy link
Contributor

We also wouldn't want to remove the MathUtil methods immediately, instead deprecating them to be removed the year after.

@leongmichael leongmichael deleted the replace-mathutilclamp branch September 24, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state: blocked Something is blocking action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MathUtil.clamp() with Java 21 Math.clamp()
3 participants
@leongmichael @calcmogul @KangarooKoala