Fix swapping of left and right paths #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamCarlberg
suggested changes
Jan 28, 2019
| @@ -337,9 +337,9 @@ private void buildPaths() { | |||
| TankModifier tank = path.getTankModifier(); | |||
| Pathfinder.writeToCSV(new File(output, path.getPathNameNoExtension() + ".pf1.csv"), | |||
| tank.getSourceTrajectory()); | |||
| Pathfinder.writeToCSV(new File(output, path.getPathNameNoExtension() + ".left.pf1.csv"), | |||
| tank.getLeftTrajectory()); | |||
| Pathfinder.writeToCSV(new File(output, path.getPathNameNoExtension() + ".right.pf1.csv"), | |||
There was a problem hiding this comment.
Should leave a comment here to explain the hack and why the left path goes to the right-side file and vice-versa.
SamCarlberg
approved these changes
Jan 28, 2019
|
This is a hack to fix for this season. Through some extensive investigating, it seems that our orientation of the coordinate system causes this issue. To prevent breaking changes in 2019, the coordinate system will be fixed for the 2020 season. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #137.