Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #941 Remove unused step in plan select modal #945

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

remyperona
Copy link
Contributor

Description

Fixes #941

Remove unused step in plan select modal, to go directly from plan select to the checkout page

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

  • Display the upgrade plan modal
  • Select a plan
  • next page is the checkout page

Technical description

Documentation

Removed a lot of unused code, related to the old step + one time plans. Also removed unnecessary request to get the number of images optimized and related data.

Update the JS code to go to the appropriate checkout page depending on the plan and period selected.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

Unticked items justification

No code coverage possible for the code changed in this PR

@remyperona remyperona added this to the 2.2.4 milestone Dec 18, 2024
@remyperona remyperona requested a review from a team December 18, 2024 22:36
@remyperona remyperona self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose plan button shall redirect to checkout
1 participant