Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCQ: eth_call_with_finality #3460

Merged
merged 2 commits into from
Oct 30, 2023
Merged

CCQ: eth_call_with_finality #3460

merged 2 commits into from
Oct 30, 2023

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Oct 23, 2023

This PR adds a new CCQ per-chain query type of eth_call_with_finality that allows the integrator to initiate a query request with a given block ID and request that the query be delayed until the block reaches the specified finality ("finalized" or "safe").

@bruce-riley bruce-riley force-pushed the ccq/eth_call_with_finality branch 3 times, most recently from dbe6090 to 4103ed4 Compare October 24, 2023 20:24
@bruce-riley bruce-riley changed the title DRAFT: CCQ: eth_call_with_finality CCQ: eth_call_with_finality Oct 25, 2023
@bruce-riley bruce-riley marked this pull request as ready for review October 25, 2023 13:31
@evan-gray evan-gray requested a review from SEJeff October 25, 2023 14:34
evan-gray
evan-gray previously approved these changes Oct 26, 2023
node/pkg/query/request.go Outdated Show resolved Hide resolved
node/pkg/query/request.go Outdated Show resolved Hide resolved
node/pkg/query/response.go Outdated Show resolved Hide resolved
node/pkg/query/response.go Show resolved Hide resolved
node/pkg/watchers/evm/ccq.go Outdated Show resolved Hide resolved
node/pkg/watchers/evm/ccq.go Show resolved Hide resolved
panoel
panoel previously approved these changes Oct 26, 2023
@bruce-riley bruce-riley reopened this Oct 26, 2023
@bruce-riley bruce-riley dismissed stale reviews from panoel and evan-gray via 866603e October 26, 2023 18:54
@bruce-riley bruce-riley force-pushed the ccq/eth_call_with_finality branch 3 times, most recently from d5c3233 to efc3975 Compare October 26, 2023 19:30
node/cmd/ccq/parse_config_test.go Show resolved Hide resolved
node/cmd/ccq/utils.go Show resolved Hide resolved
node/cmd/ccq/utils.go Show resolved Hide resolved
node/cmd/ccq/utils.go Show resolved Hide resolved
node/pkg/query/query_test.go Show resolved Hide resolved
node/pkg/watchers/evm/ccq.go Show resolved Hide resolved
node/pkg/watchers/evm/ccq.go Show resolved Hide resolved
node/pkg/watchers/evm/watcher.go Show resolved Hide resolved
whitepapers/0013_ccq.md Show resolved Hide resolved
node/pkg/query/request.go Show resolved Hide resolved
@bruce-riley bruce-riley merged commit b708f5a into main Oct 30, 2023
22 checks passed
@bruce-riley bruce-riley deleted the ccq/eth_call_with_finality branch October 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants