Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy scroll to testnet #3429

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Deploy scroll to testnet #3429

merged 3 commits into from
Nov 8, 2023

Conversation

bruce-riley
Copy link
Contributor

No description provided.

@bruce-riley bruce-riley force-pushed the deploy_scroll_testnet branch 5 times, most recently from 1a539b5 to 8915603 Compare October 10, 2023 20:02
@bruce-riley bruce-riley marked this pull request as ready for review November 7, 2023 22:41
panoel
panoel previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@panoel panoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the node/* files

evan-gray
evan-gray reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Scroll supports finalized and safe can we add it to the list in getFinality?

a5-pickle
a5-pickle approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust/core looks good

SEJeff
SEJeff approved these changes Nov 8, 2023
View reviewed changes
devnet/node.yaml Show resolved Hide resolved
@bruce-riley bruce-riley merged commit 0a89e23 into main Nov 8, 2023
22 checks passed
@bruce-riley bruce-riley deleted the deploy_scroll_testnet branch November 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEJeff SEJeff SEJeff approved these changes

@kcsongor kcsongor kcsongor approved these changes

@a5-pickle a5-pickle a5-pickle approved these changes

@panoel panoel panoel approved these changes

@evan-gray evan-gray evan-gray approved these changes

@kev1n-peters kev1n-peters kev1n-peters approved these changes

@barnjamin barnjamin Awaiting requested review from barnjamin

@gator-boi gator-boi Awaiting requested review from gator-boi gator-boi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bruce-riley @SEJeff @kcsongor @a5-pickle @panoel @evan-gray @kev1n-peters