AutoRelayer: VaaKey -> MessageKey #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should likely be a forge test testing message key end-to-end right (maybe just with the key being 'identify token bridge message' or something?) - would likely require updates to the MockGenericRelayer to support that message key type edit: Oh I think I see - you did the updates to mockgenericrelayer by just having it be true always but still, maybe at least one forge test that uses MessageKeys end to end would be ideal! |
JoeHowarth
force-pushed
the
auto-relayer/message-key
branch
from
bfbc383
to
95f3e38
Compare
JoeHowarth
changed the base branch from
auto-relayer/cheap-cross-chain-refunds
to
auto-relayer/rm-forwards
JoeHowarth
requested review from
derpy-duck,
a5-pickle,
gator-boi and
kcsongor
as code owners
JoeHowarth
force-pushed
the
auto-relayer/message-key
branch
from
4433022
to
e02a624
Compare
derpy-duck
reviewed
Aug 21, 2023
| @@ -195,7 +225,37 @@ abstract contract WormholeRelayerSend is WormholeRelayerBase, IWormholeRelayerSe | |||
| refundChain, | |||
| refundAddress, | |||
| deliveryProviderAddress, | |||
| vaaKeys, | |||
| WormholeRelayerSerde.vaaKeyArrayToMessageKeyArray(vaaKeys), // why doesn't this work without the 'WormholeRelayerSerde.' ? | |||
There was a problem hiding this comment.
I think you'd have to write vaaKeys.vaaKeyArrayToMessageKeyArray() if you wanted to do this. Not certain, but worth a shot
derpy-duck
reviewed
Aug 21, 2023
| @@ -112,7 +114,7 @@ abstract contract WormholeRelayerDelivery is WormholeRelayerBase, IWormholeRelay | |||
| } | |||
|
|
|||
| // Revert if the VAAs delivered do not match the descriptions specified in the instruction | |||
| checkVaaKeysWithVAAs(instruction.vaaKeys, encodedVMs); | |||
| checkMessageKeysWithMessagess(instruction.messageKeys, encodedVMs); | |||
There was a problem hiding this comment.
maybe fix this typo - 'Messages'
derpy-duck
reviewed
Aug 21, 2023
| function checkVaaKeysWithVAAs( | ||
| VaaKey[] memory vaaKeys, | ||
| bytes[] memory signedVaas | ||
| function checkMessageKeysWithMessagess( |
derpy-duck
approved these changes
Aug 21, 2023
|
encodeVaaKeyArray can be removed from WormholeRelayerSerde by the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design doc
https://www.notion.so/wormholefoundation/AR-Supports-CCTP-f1f58f0daacc4f37a67e922244e51205