Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] CCQ: Cross-Chain Query Integration #2981

Closed
wants to merge 37 commits into from
Closed

[DRAFT] CCQ: Cross-Chain Query Integration #2981

wants to merge 37 commits into from

Conversation

evan-gray
Copy link
Contributor

@evan-gray evan-gray commented May 24, 2023 •
edited by bruce-riley
Loading

WARNING: This PR has been superseded by the following PRs:

Please DO NOT add any more commits to this PR!

@evan-gray evan-gray force-pushed the ccq/integration branch 3 times, most recently from f47465c to 9473511 Compare May 25, 2023 19:20
kev1n-peters
kev1n-peters previously approved these changes Jun 2, 2023
View reviewed changes
@kev1n-peters kev1n-peters self-requested a review June 2, 2023 14:39
@bruce-riley bruce-riley changed the title [DRAFT] Cross-Chain Query Integration [DRAFT] CCQ: Cross-Chain Query Integration Jun 2, 2023
bruce-riley
bruce-riley previously approved these changes Jun 2, 2023
View reviewed changes
@tbjump tbjump self-requested a review June 8, 2023 17:39
@evan-gray evan-gray dismissed stale reviews from bruce-riley and kev1n-peters via 788b620 June 12, 2023 13:09
@tbjump
Copy link
Contributor

tbjump commented Aug 2, 2023

Linking #3113 here as related.

@tbjump
Copy link
Contributor

tbjump commented Aug 2, 2023

Some feedback on the gossipsub portion of this (If you decide to proceed with gossipsub at all):

  • CCQ requests and responses should go into their own pub/sub topics ccq_requests and ccq_responses (or similar)
  • Guardians should instantiate a separate PubSub struct (pubsub.NewGossipSub(…)) for CCQ-related stuff (not join additional topics with the existing ps)
  • The CCQServers (ccq: query server #3113) should be identified and allow-listed with their libp2p identity.
  • CCQServers should have a parameter of D = 36, Dlo = 19, Dhi = 40, Dout = 18 such that they can reach all Guardians directly. There will be no other nodes forwarding messages (or at least they cannot be assumed to exist), so it’s important that all Guardians can be reached directly.
  • Guardians should implement option WithPeerFilter to only connect to allow-listed CCQServers and also implement WithDirectPeers to maintain connections to all CCQServers.

@evan-gray evan-gray force-pushed the ccq/integration branch 2 times, most recently from d6af84e to ab49d0f Compare August 29, 2023 13:26
@bruce-riley bruce-riley force-pushed the ccq/integration branch 2 times, most recently from f282ed7 to b2e7700 Compare September 5, 2023 18:46
bruce-riley and others added 21 commits September 29, 2023 13:51
@bruce-riley
CCQ: Validation and marshalling changes (#3017)
dbcf8d5
@kev1n-peters @bruce-riley
CCQ: Added integration test
0720224
@bruce-riley @panoel
CCQ: Batch queries (#3023)
20799c8 
* CCQ: Add marshalling tests

* More marshalling changes

* Start of support for multiple calls in a batch

* Multiple responses to go with multiple requests

* Support multiple EVM queries in a batch

* Multiple queries in a batch

* Start of handler tests

* More handler tests

* More handler tests

* node: add multi batch query tests

* Added comments to tests

* Per chain query time out not getting retried

* node: chang rand package

* Tweak serialization of per call request

---------

Co-authored-by: Paul Noel <[email protected]>
@panoel @bruce-riley
tilt: deploy core and token bridge to wormchain (#3084)
0f3634a 
* wormchain: deploy more contracts in tilt

* wormchain: change contract ordering

* wormchain: rearrange instantiation
@bruce-riley
CCQ: Messaging changes (#3093)
9ddee1a 
* CCQ: Messaging changes

* Add tests for marshaling query request

* Response changes

* Rework response structs, add tests

* Code review rework

* Make block number uint64 internally
@bruce-riley
CCQ: Reorg code into a query package (#3112)
f2a0611 
* CCQ: Reorg code into a query package

* Make requestTimeout public
@bruce-riley
CCQ: Message tweaks (#3147)
abecbb7 
* CCQ: Message tweaks

Change-Id: I5d97fa0a32b42f1a763edf572b3d08365a7f5b20

* Add comments

Change-Id: I35a9fac0fbaae7d175e2529b842c5cef4ac386f6

* Fix comment paste error

Change-Id: I4dd23ea375e481d46e24a11d70b590221548c92e

* Address review comments

Change-Id: Ia516085fdcc182a5566b31342a5aa2480d37eedc
@bruce-riley
CCQ: Make work with node refactor (#3154)
e1fd3b4 
* CCQ: Make work with node refactor

Change-Id: I416db0e01156787b6ed2420598a448d23c4581ca

* Tweak log message

Change-Id: Ibf109cfdccf01297e0755fc849b23d42cde2b772
@evan-gray @bruce-riley
CCQ: revert polygonRPC
064ffa0
@evan-gray @bruce-riley
CCQ: evm example
7f2ad4a
@bruce-riley
Rework to support batches
46c8127
@bruce-riley
Start using forge tests
977618c
@bruce-riley
Convert to a library
d8f84c2
@kev1n-peters @bruce-riley
ccq: Query Server (#3113)
97b5822 
The CCQ Query Server is an HTTP server / RESTful service that handles
query requests, publishes them to the gossip network, waits for the
responses to reach quorum, and then returns the response.
@kev1n-peters @bruce-riley
sdk/js-query: initial commit
bf29fb4
@bruce-riley
CCQ: Gossip split (#3320)
31a7555 
* CCQ: Gossip Split

* Fix error handling
@bruce-riley
CCQ: Server allow list (#3347)
69dfd25
@bruce-riley
CCQ: Add some sdk tests (#3357)
30c4751
@bruce-riley
CCQ: ccq_server health check (#3365)
a97a786
@bruce-riley
CCQ: Abstract contract
328b6de
@bruce-riley
CCQ: Server allow unsigned requests (#3379)
e079566
bruce-riley and others added 6 commits October 1, 2023 11:31
@bruce-riley @evan-gray
CCQ: Query demo contract (#3373)
81f102d 
* CCQ: Add enable flag and feature flag (#2986)

* CCQ: Add enable flag and feature flag

* Fix build error

* CCQ: Add ccqAllowedRequesters parameter (#2990)

* CCQ: Query demo contract

* More stuff

* More stuff

* More changes

* remove bad check

* timestamp bugfix

* Code review rework

---------

Co-authored-by: Evan Gray <[email protected]>
@bruce-riley
CCQ: Fix tilt CI tests (#3410)
5c92689 
* CCQ: Fix tilt CI tests

* Add logging

* Try adding second guardian to bootstrap peers

* More debugging

* Another tweak

* Try again

* Undo a tweak

* Sigh

* Shrug

* Give query-server a unique p2p key
@bruce-riley
CCQ: Query server CORS change (#3415)
2067e47
@bruce-riley
CCQ: Query server env is hard coded to devnet (#3417)
e5efea2
@bruce-riley
CCQ: Ethereum parsing library rework (#3404)
7dfe9c4 
* CCQ: Eth parsing library rework

* Use BytesParsing for unchecked handling

* Add checkLength()

* Use a const instead of a magic number
@bruce-riley
CCQ: Eth library gas tweaks (#3420)
33823dc
@evan-gray evan-gray closed this Jan 30, 2024
@evan-gray evan-gray deleted the ccq/integration branch January 30, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gator-boi gator-boi gator-boi left review comments

@bruce-riley bruce-riley bruce-riley left review comments

@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters kev1n-peters is a code owner

@tbjump tbjump Awaiting requested review from tbjump

@panoel panoel Awaiting requested review from panoel panoel will be requested when the pull request is marked ready for review panoel is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff will be requested when the pull request is marked ready for review SEJeff is a code owner

@a5-pickle a5-pickle Awaiting requested review from a5-pickle a5-pickle will be requested when the pull request is marked ready for review a5-pickle is a code owner

@kcsongor kcsongor Awaiting requested review from kcsongor kcsongor will be requested when the pull request is marked ready for review kcsongor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evan-gray @tbjump @gator-boi @kev1n-peters @bruce-riley @panoel