Node/EVM: More nodes support finalized and safe (#3467)

* Node/EVM: More nodes support finalized and safe * Remove unused finalizers
wormhole-foundation · Oct 26, 2023 · bd7262d · bd7262d
1 parent 5afd9ea
commit bd7262d
Show file tree

Hide file tree

Showing 7 changed files with 71 additions and 472 deletions.
diff --git a/node/cmd/guardiand/node.go b/node/cmd/guardiand/node.go
@@ -1079,11 +1079,10 @@ func runNode(cmd *cobra.Command, args []string) {
 
 	if shouldStart(bscRPC) {
 		wc := &evm.WatcherConfig{
-			NetworkID:            "bsc",
-			ChainID:              vaa.ChainIDBSC,
-			Rpc:                  *bscRPC,
-			Contract:             *bscContract,
-			WaitForConfirmations: true,
+			NetworkID: "bsc",
+			ChainID:   vaa.ChainIDBSC,
+			Rpc:       *bscRPC,
+			Contract:  *bscContract,
 		}
 
 		watcherConfigs = append(watcherConfigs, wc)

diff --git a/node/pkg/watchers/evm/finalizers/arbitrum.go b/node/pkg/watchers/evm/finalizers/arbitrum.go
diff --git a/node/pkg/watchers/evm/finalizers/arbitrum_test.go b/node/pkg/watchers/evm/finalizers/arbitrum_test.go
diff --git a/node/pkg/watchers/evm/finalizers/moonbeam.go b/node/pkg/watchers/evm/finalizers/moonbeam.go
diff --git a/node/pkg/watchers/evm/finalizers/moonbeam_test.go b/node/pkg/watchers/evm/finalizers/moonbeam_test.go
diff --git a/node/pkg/watchers/evm/finalizers/neon_test.go b/node/pkg/watchers/evm/finalizers/neon_test.go
@@ -15,6 +15,15 @@ import (
 	"go.uber.org/zap"
 )
 
+// mockL1Finalizer implements the L1Finalizer interface for testing purposes.
+type mockL1Finalizer struct {
+	LatestFinalizedBlockNumber uint64
+}
+
+func (m *mockL1Finalizer) GetLatestFinalizedBlockNumber() uint64 {
+	return m.LatestFinalizedBlockNumber
+}
+
 func TestNeonErrorReturnedIfBlockIsNil(t *testing.T) {
 	ctx := context.Background()
 	logger := zap.NewNop()