-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: Port 'Screencast' demo to Vala #180
base: main
Are you sure you want to change the base?
Conversation
The current code does not work, Gstreamer Pipeline is causing issues.
@Diego-Ivan I'd appreciate a review :). I don't think I understand how the pipeline works correctly |
It needs to
I'm really not a GStreamer guy, but up to my understanding, this is how it works:
|
I did try calling |
Explicit variable declaration Changed the way node_id is accessed with a more proper way to get elements from the touple Skip Gst.state enum
Replace enclosing whole method in try catch Throw an error from start_screencast_session() Declare portal and parent as global for easier access
@BharatAtbrat I use this very ugly workaround to test it: unowned string[] workaround = null;
Gst.init (ref workaround); But I think this is an issue with the Vala bindings, it should allow null. |
Is this still an issue with 47? |
Unfortunately yes, but I think we can use the workaround I suggested to have this merged. I don't think it would be a big deal. Just tested the demo and it works perfectly, thank you so much @BharatAtbrat ! |
Workaround as suggested by @Diego-Ivan Demo functions as expected
I don't think this second use of the function can be expressed in the Vala bindings, you probably would need to create a second binding for the function that executed it with null values. Maybe |
Adding it directly brings up an error saying the name |
What do you mean with "adding directly"? I meant changing the vapi |
Oh my bad :P, I thought this already existed |
The current code does not work, the GStreamer Pipeline is causing issues. There might be some problems with the implementation
Note - The Camera port also does not work because it uses
Gst Pipeline
.Screengrab of the error :
2024-06-14.23-00-30.mp4