Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port View Switcher to python #109

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

imhemish
Copy link
Contributor

It's my first time contributing to Workbench. Hope it's all good! Waiting for listening to any more suggestions or changes!

@rolandlo
Copy link
Contributor

Compare this PR and comments.
Also see Language support table for other PRs.

@sonnyp
Copy link
Contributor

sonnyp commented Feb 29, 2024

@imhemish nice to see you here, thank you for contributing

yeah I'm afraid as @rolandlo pointed out this was already work in progress workbenchdev/Workbench#726
I'l close this one, and we can move the conversation there.

EDIT: nevermind - I've reopen this one since it is open against the right repo

We are sort of complete now with the Python port so if you want to contribute here are options

  • make new demos
  • improve existing ones
  • contribute to Workbench itself

Here are source of inspirations #3

@sonnyp sonnyp closed this Feb 29, 2024
@sonnyp sonnyp reopened this Feb 29, 2024
Copy link
Contributor

@theCapypara theCapypara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your first contribution! Works perfectly & great idea to use get_ancestor


def on_button_clicked(button: Gtk.Button, *_):
notifications_page.props.badge_number -= 1
notification_list.remove(button.get_ancestor(Adw.ActionRow))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@theCapypara theCapypara merged commit 6c3c514 into workbenchdev:main Feb 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants