Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare "Classes" for conversion to folders #23735

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

jkmassel
Copy link
Contributor

@jkmassel jkmassel commented Oct 31, 2024

Prerequisite for #23629 – we can't adopt folders until we drop CocoaPods, but all of the hard work can be done in advance.

This PR aligns the file system and the project.

To Test:

  • Ensure this PR builds in CI
  • Open the project in Xcode, right-click on the "Classes" directory, hold Option, then click Preflight Conversion to Folder. Note that it says “Classes” is ready to be converted to a folder.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 31, 2024

3 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 31, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23735-057e6fa
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit057e6fa
App Center BuildWPiOS - One-Offs #10916
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 31, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23735-057e6fa
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit057e6fa
App Center Buildjetpack-installable-builds #9956
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jkmassel jkmassel marked this pull request as ready for review October 31, 2024 00:39
@jkmassel jkmassel added this to the 25.5 milestone Oct 31, 2024
@jkmassel jkmassel added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@jkmassel jkmassel added this pull request to the merge queue Oct 31, 2024
Merged via the queue into trunk with commit 1bfc100 Oct 31, 2024
24 of 25 checks passed
@jkmassel jkmassel deleted the fix/project-organization branch October 31, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants