Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move changes to branch 513-machine-translate-tutorial #603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpjjj1222
Copy link
Contributor

Context

This PR extends the machine translate feature in the verify-locales script to support tutorials.

Related issues

Verification

Tested with es-MX-tutorial.json:

  1. The file contained an untranslated $? in the Line array.
  2. I tested whether the Google Translate API could successfully translate $? by running the updated verify-locales.ts script.
  3. After running the script, I verified that the new es-MX-tutorial.json was generated correctly, with the $? replaced by the translated content.

Note:

  1. I noticed that the contributor who added $? had made a mistake: there should have been five $? entries in the Line array, representing five lines of dialogue, instead of just one. So, I corrected the file by replacing the single $? with five $?, then re-ran the verify-locales.ts script. The script processed the corrected Line array and generated the expected output, confirming the functionality works as intended.

  2. I discovered that the language and region fields in zh-TW-tutorial.json were incorrect while trying to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Machine translate tutorial
1 participant