Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: remove some ci environment variables #3846

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 26, 2024

remove some environment variables who are either the same value or make no sense to exist in the first place:

CI_STEP_STATUS
CI_STEP_FINISHED
CI_PIPELINE_STATUS
CI_PIPELINE_FINISHED

CI_STEP_STATUS
CI_STEP_FINISHED
CI_PIPELINE_STATUS
CI_PIPELINE_FINISHED
@6543 6543 added the breaking will break existing installations if no manual action happens label Jun 26, 2024
@anbraten
Copy link
Member

Could we remove those things just-in-time when we release 3.0. Those PRs will probably be quite outdated and need updates as we are constantly adding new deprecations til we release 3.0.

@qwerty287
Copy link
Contributor

We should do 3.0 soon I think. There are enough breaing changes and deprecations collected. Maybe after 2.7.0?

@anbraten
Copy link
Member

anbraten commented Jun 27, 2024

We should do 3.0 soon I think. There are enough breaing changes and deprecations collected. Maybe after 2.7.0?

I would like to like to do it earliest end of the year. We should provide the community some time between major releases and the breaking changes we would currently apply aren't that critical IMO and the benefits from a users perspective are rather minimal atm.

@zc-devs
Copy link
Contributor

zc-devs commented Jun 27, 2024

I would add DRONE_* to the list.

@qwerty287
Copy link
Contributor

We keep the drone vars to be compatible to drone plugins.

@6543 6543 added the blocked It's ready but something external is blocking it label Jun 27, 2024
@6543
Copy link
Member Author

6543 commented Jun 27, 2024

... Those PRs will probably be quite outdated and need updates as we are constantly adding new deprecations til we release 3.0.

yes I just want to start adding the changes here and I'll peridically resolve conflicts and update it etc ... as it's easuly forgotten otherwise

@anbraten anbraten added this to the 3.x.x milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked It's ready but something external is blocking it breaking will break existing installations if no manual action happens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants