Fixes for PHP8 and static analysis #1006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes some improvements to docblock comments to improve static analysis and fixes some issues found by verifying PHP8 compatibility.
prettyboymp
requested review from
a team and
jorgeatorres
and removed request for
a team
jorgeatorres
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Hey @prettyboymp!
Thanks for submitting these fixes. Overall this looks good, but I left some questions/comments. Please let me know what you think.
| @@ -711,7 +711,7 @@ protected function bulk_cancel_actions( $query_args ) { | |||
|
|
|||
| while ( $action_ids ) { | |||
| $action_ids = $this->query_actions( $query_args ); | |||
| if ( empty( $action_ids ) ) { | |||
| if ( empty( $action_ids ) || ! is_countable( $action_ids ) ) { | |||
There was a problem hiding this comment.
I don't think query_actions() can return anything other than an array. Is this check really needed here?
| @@ -142,6 +142,7 @@ private function init_logging() { | |||
| WP_CLI::debug( 'Beginning migration of batch: ' . print_r( $batch, true ) ); | |||
| }, 10, 1 ); | |||
| add_action( 'action_scheduler/migration_batch_complete', function ( $batch ) { | |||
| /** @var array $batch */ | |||
There was a problem hiding this comment.
Does this truly have any effect at this location in the code?
| @@ -94,7 +94,8 @@ public function __construct($expression, CronExpression_FieldFactory $fieldFacto | |||
| */ | |||
| public function setExpression($value) | |||
| { | |||
| $this->cronParts = preg_split('/\s/', $value, -1, PREG_SPLIT_NO_EMPTY); | |||
| $cronParts = preg_split('/\s/', $value, -1, PREG_SPLIT_NO_EMPTY); | |||
| $this->cronParts = is_array($cronParts) ? $cronParts : []; | |||
There was a problem hiding this comment.
For consistency with WP coding standards:
Suggested change
| $this->cronParts = is_array($cronParts) ? $cronParts : []; | |
| $this->cronParts = is_array( $cronParts ) ? $cronParts : array(); |
jorgeatorres
added
has feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some improvements to docblock comments to improve static analysis and fixes some issues found by verifying PHP8 compatibility.