Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax interactivity improvements #917

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

markusstoll
Copy link
Contributor

This is my promised pull request with the multiple update feature that I presented during WODay 2019 on April 11th in Frankfurt.

Basically I enable Ajax actions to have more than one updateContainerId as target (a comma separated string with multiple IDs or an NSArray of ids) where all referred containers will be updated in one single response.
I added an instructive example in AjaxExample app.

I understand that it will be hard to review the stuff as it goes deep into the Ajax framework. Maybe we should ask some others to take a look on it. I know @hugith would like to use it, maybe he can take a deeper look, too.

regards, Markus

@markusstoll
Copy link
Contributor Author

About the Travis CI failure… this does not look like a problem with my code, odes it?

@fbarthez
Copy link
Contributor

About the Travis CI failure… this does not look like a problem with my code, odes it?

No, that looks like a travis issue. We may have to switch to a more recent JDK. I'll try to have a closer look later today.

@fbarthez
Copy link
Contributor

fbarthez commented Jul 9, 2019

Hi Markus, sorry for taking so long. Could you rebase your branch on the current master and then force a push? I did that and got travis to successfully build on my fork.

@markusstoll markusstoll force-pushed the Ajax_interactivityImprovements branch from d92ef2e to ba2e1f7 Compare July 9, 2019 19:27
@markusstoll
Copy link
Contributor Author

sorry, did not work out

@hugithordarson
Copy link
Contributor

Just returned from a string of summer vacations and have been putting off checking this out. Finally back at the desk and looking forward to taking a look :). Thanks for all the work Markus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants