Revert "Merge pull request #342 from smarthealth/hotfix-erxec"

This reverts commit 1ae0143, reversing changes made to 0f9d473.
wocommunity · Jan 29, 2013 · ffa79f2 · ffa79f2
1 parent 1ae0143
commit ffa79f2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 51 deletions.
diff --git a/Frameworks/Core/ERExtensions/Sources/er/extensions/eof/ERXEC.java b/Frameworks/Core/ERExtensions/Sources/er/extensions/eof/ERXEC.java
@@ -171,9 +171,6 @@ public class ERXEC extends EOEditingContext {
 	private static final NSSelector EditingContextWillRevertObjectsDelegateSelector = new NSSelector("editingContextWillRevertObjects", new Class[] { EOEditingContext.class, NSArray.class, NSArray.class, NSArray.class });
 	private static final NSSelector EditingContextDidRevertObjectsDelegateSelector = new NSSelector("editingContextDidRevertObjects", new Class[] { EOEditingContext.class, NSArray.class, NSArray.class, NSArray.class });
 	private static final NSSelector EditingContextDidFailSaveChangesDelegateSelector = new NSSelector("editingContextDidFailSaveChanges", new Class[] { EOEditingContext.class, EOGeneralAdaptorException.class });
-
-	private static final String ERXECProcessQueuedNotificationsNotification = "processQueuedNotifications";
-	public static final NSSelector ERXECProcessQueuedNotificationsSelector = ERXSelectorUtilities.notificationSelector("processQueuedNotificationsNotification");
 
 	/**
 	 * @return the value of the <code>er.extensions.ERXEC.editingContextClassName</code> property, which
@@ -1486,20 +1483,7 @@ public Object invokeRemoteMethod(EOEditingContext eoeditingcontext, EOGlobalID e
 	@Override
 	public void _objectsChangedInStore(NSNotification nsnotification) {
 		ERXEnterpriseObject.FlushCachesProcessor.perform(this, (NSArray) nsnotification.userInfo().objectForKey("objects"));
-
-		/*
-		 * Check to see if this context, or any parent context, is saving changes. 
-		 * If so, queue up the notifications.
-		 */
-		boolean isSavingChanges = savingChanges;
-		EOObjectStore parent = parentObjectStore();
-		while(!isSavingChanges && parent instanceof ERXEC) {
-			ERXEC parentEc = (ERXEC) parent;
-			isSavingChanges = parentEc.savingChanges;
-			parent = parentEc.parentObjectStore();
-		}
-
-		if (isSavingChanges) {
+		if (savingChanges) {
 			synchronized (queuedNotifications) {
 				queuedNotifications.addObject(nsnotification);
 			}
@@ -1582,11 +1566,6 @@ private void processQueuedNotifications() {
 		for (NSNotification notification : queuedNotificationsClone) {
 			_objectsChangedInStore(notification);
 		}
-		NSNotificationCenter.defaultCenter().postNotification(ERXECProcessQueuedNotificationsNotification, this);
-	}
-
-	public void processQueuedNotificationsNotification(NSNotification n) {
-		processQueuedNotifications();
 	}
 
 	/**
@@ -1752,10 +1731,6 @@ public EOEditingContext _newEditingContext(EOObjectStore objectStore, boolean va
 				ec.unlock();
 			}
 			NSNotificationCenter.defaultCenter().postNotification(EditingContextDidCreateNotification, ec);
-			if(objectStore instanceof ERXEC) {
-				ERXEC parent = (ERXEC)objectStore;
-				NSNotificationCenter.defaultCenter().addObserver(ec, ERXECProcessQueuedNotificationsSelector, ERXECProcessQueuedNotificationsNotification, parent);
-			}
 			return ec;
 		}
 

diff --git a/Tests/ERXTest/Sources/er/extensions/eof/ERXECTest.java b/Tests/ERXTest/Sources/er/extensions/eof/ERXECTest.java
@@ -18,7 +18,6 @@
 import er.erxtest.ERXTestCase;
 import er.erxtest.ERXTestUtilities;
 import er.erxtest.model.Company;
-import er.erxtest.model.Employee;
 
 public class ERXECTest extends ERXTestCase {
 
@@ -53,30 +52,6 @@ public void testConstructorWithObjectStore() {
         Assert.assertEquals(parentEC3, ec3.parentObjectStore());
     }
 
-    public void testNestedECs() {
-    	try {
-	    	EOEditingContext ec = ERXEC.newEditingContext();
-    		Company c = (Company) EOUtilities.createAndInsertInstance(ec, Company.ENTITY_NAME);
-    		c.setName("Name");
-    		ec.saveChanges();
-    		EOEditingContext nested = ERXEC.newEditingContext(ec);
-    		Company nestC = c.localInstanceIn(nested);
-    		Employee e = (Employee) EOUtilities.createAndInsertInstance(nested, Employee.ENTITY_NAME);
-    		e.setFirstName("First");
-    		e.setLastName("Last");
-    		e.setManager(Boolean.FALSE);
-    		e.addObjectToBothSidesOfRelationshipWithKey(nestC, Employee.COMPANY_KEY);
-    		nested.saveChanges();
-    		ec.saveChanges();
-	    	System.gc();
-    		c.delete();
-    		ec.saveChanges();
-    	} catch (Exception e) {
-    		e.printStackTrace();
-    		Assert.fail(e.getMessage());
-    	}
-    }
-
     public void testSerializablilty() throws IOException, ClassNotFoundException {
 		EOEditingContext ec = ERXEC.newEditingContext();
 		Company.createCompany(ec, "Some fruit company");