Fix errors seen on test deployment server #95
+90
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Loftus
commented
Dec 2, 2024
| @@ -234,7 +234,7 @@ export default defineComponent({ | |||
| const nextDate = new Date(d.toISOString()); | |||
| this.iterDate(nextDate); | |||
| try { | |||
| const response = await fetchWithToken(`${window.VUE_APP_OAPI}/collections/${station.properties.topic}/items?f=json&datetime=${nextDate.toISOString()}/..&sortby=+resultTime&index=${index}&limit=1&wigos_station_identifier=${station.id}`); | |||
| const response = await fetchWithToken(`${window.VUE_APP_OAPI}/collections/${station.properties.topic}/items?f=json&datetime=${nextDate.toISOString()}/..&sortby=resultTime&index=${index}&limit=1&wigos_station_identifier=${station.id}`); | |||
There was a problem hiding this comment.
Got rid of the + on the sort here since it was causing the fetch to fail.
Not super clear if pygeoapi supports that. If I remove + it works fine. @webb-ben please let me know if I am missing something here.
There was a problem hiding this comment.
if no +/- indicated, + is assumed, issue happens when the URL is serialized. Better to leave out
C-Loftus
commented
Dec 2, 2024
| @@ -23,7 +23,12 @@ | |||
| </v-card> | |||
| </template> | |||
| <template v-else> | |||
| <i>{{ $t("messages.no_observations_in_collection") }}</i> | |||
There was a problem hiding this comment.
I originally added this but I think it is bad UX so removed it and kept it the same as the UI currently has (i.e. no extra italic message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, the non-synop collection seems to be registered with the wrong URL. When I fetch all the collections, the non-synop has a url whic points to http://136.156.130.194/oapi/collections/urn:wmo:md:test3:core.surface-based-observations.drifting-buoys.PROGRAM?f=json This is coming from pygeoapi directly. The
PROGRAMpart is capitalized but it shouldn't be. I can make this lowercase after fetching but wanted to clarify this since I believe it is directly from the test server and not caused by the UI.Will add tests in future iteration once allign on these changes