Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FT2021_2RC2 #272

Closed
wants to merge 8 commits into from
Closed

FT2021_2RC2 #272

wants to merge 8 commits into from

Conversation

blchoy
Copy link
Member

@blchoy blchoy commented Jul 15, 2021 •
edited
Loading

First commit of IWXXM 2021-2RC2. Significant changes include:

  1. Implement changes to SIGMET in Amendment 79 Discussion 267, including the schema/schematron rules and examples.
  2. Update examples of SIGMET, VAA and SWA to correct the orientation (counter-clockwise) of the points in a polygon enclosing a phenomenon
  3. Change the version of all schemas and examples from RC1 to RC2.

Do not squash and merge this PR. Only check and approve the changes and leave this branch untouched.

mgoberfield
mgoberfield suggested changes Jul 15, 2021
View reviewed changes
IWXXM/iwxxm-collect.xsd Outdated
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<schema elementFormDefault="qualified" xmlns="http://www.w3.org/2001/XMLSchema">
<import namespace="http://icao.int/iwxxm/2021-2" schemaLocation="http://schemas.wmo.int/iwxxm/2021-2RC1/iwxxm.xsd"/>
<import namespace="http://icao.int/iwxxm/3.0" schemaLocation="http://schemas.wmo.int/iwxxm/3.0/iwxxm.xsd"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? Is this correct, @blchoy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is an old file. Fixed in commit 14b70a0

IWXXM/sigmet.xsd Outdated
<annotation>
<documentation>SIGMET reporting constructs as defined in ICAO Annex 3 / WMO No. 49-2.
<!--Generated by Enterprise Architect 12.1.1224 ( Build: 1224 )-->
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" targetNamespace="http://icao.int/iwxxm/2021-2" xmlns:iwxxm="http://icao.int/iwxxm/2021-2" version="4.0.0RC2" xmlns:gml="http://www.opengis.net/gml/3.2" xmlns:metce="http://def.wmo.int/metce/2013">
Copy link
Contributor

@mgoberfield mgoberfield Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this schema file been correctly post-processed from EA output? I see that XSchema is not the default namespace in the resulting file. With the xs: prefix present in every line, it obscures the significant changes between RC1 and RC2.

Copy link
Member Author

@blchoy blchoy Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The post-processing script got stuck after I deleted some classes in SIGMET. Fixed in commit 14b70a0

IWXXM/WAFSSigWxFC.xsd
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<schema elementFormDefault="qualified" targetNamespace="http://icao.int/iwxxm/2021-2" version="1.0.0RC1" xmlns:iwxxm="http://icao.int/iwxxm/2021-2" xmlns:gml="http://www.opengis.net/gml/3.2" xmlns:aixm="http://www.aixm.aero/schema/5.1.1" xmlns="http://www.w3.org/2001/XMLSchema">
<schema elementFormDefault="qualified" targetNamespace="http://icao.int/iwxxm/2021-2" version="1.0.0RC2" xmlns:iwxxm="http://icao.int/iwxxm/2021-2" xmlns:gml="http://www.opengis.net/gml/3.2" xmlns:aixm="http://www.aixm.aero/schema/5.1.1" xmlns="http://www.w3.org/2001/XMLSchema">
<include schemaLocation="metFeature.xsd"></include>
<import namespace="http://www.aixm.aero/schema/5.1.1" schemaLocation="http://www.aixm.aero/schema/5.1.1/AIXM_Features.xsd"></import>
<import namespace="http://www.opengis.net/gml/3.2" schemaLocation="http://schemas.opengis.net/gml/3.2.1/gml.xsd"></import>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize @blchoy for not catching these typos in RC1.
Line 9: weakly-typed, not week-type
Line 180: replace "Oceanic and Atmospheric Administration (NOAA)" with "Weather Service (NWS)"

Copy link
Member Author

@blchoy blchoy Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 9: Fixed.
Line 180: I actually got this from WMO Common Code Table C-1 (http://codes.wmo.int/common/centre/177) which is being used in existing BUFR SIGWX files. As we are not making direct reference to this table I see no reason why we cannot change. Updated in commit 14b70a0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stumbled into NOAA vs NWS politics. 😁

jkorosi
jkorosi reviewed Jul 15, 2021
View reviewed changes
IWXXM/sigmet.xsd Outdated
The expected end of occurrence of volcanic ash ("NO VA EXP") is indicated with a missing SIGMET phenomenon with a nil reason of nothingOfOperationalSignificance</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="analysisCollection" minOccurs="0" maxOccurs="1">
Copy link

@jkorosi jkorosi Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maxOccurs should be set to maxOccurs="unbounded" to allow reporting multiple VA clouds. More than one occurrence will be used only by VA SIGMET.

VA SIGMET examples have to be updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both updated in commit 14b70a0

IWXXM/sigmet.xsd Outdated Show resolved Hide resolved
mgoberfield
mgoberfield approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@mgoberfield mgoberfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without commenting on sigmet.xsd, I approve the rest of this PR.

@blchoy
Copy link
Member Author

blchoy commented Jul 16, 2021

@amilan17 I think we can pack up and upload to schemas.wmo.int right now.

@mgoberfield mgoberfield self-requested a review July 16, 2021 10:09
@mgoberfield
Copy link
Contributor

mgoberfield commented Jul 16, 2021 •
edited
Loading

HOLD!

Please fix

iwxxm/IWXXM/tropicalCycloneAdvisory.xsd

Line 103 in 3b7d03b

<element name="cumulonimbusCloudLocation" type="iwxxm:AirspaceVolumePropertyType" minOccurs="0" maxOccurs="unbounded">

That element needs to be made nillable @blchoy. Very sorry that I did not catch this or thought of this yesterday. I realized this omission when I woke up this morning!

mgoberfield
mgoberfield approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@mgoberfield mgoberfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided the TCA element cumulonimbusCloudLocation is made nillable, I approve.

@blchoy
Copy link
Member Author

blchoy commented Jul 16, 2021

Please fix

iwxxm/IWXXM/tropicalCycloneAdvisory.xsd

Line 103 in 3b7d03b

<element name="cumulonimbusCloudLocation" type="iwxxm:AirspaceVolumePropertyType" minOccurs="0" maxOccurs="unbounded">

That element needs to be made nillable @blchoy. Very sorry that I did not catch this or thought of this yesterday. I realized this omission when I woke up this morning!

Done with commit 6136d03

Some people say their minds keep figuring out solutions when they are sleeping and will most likely get one when they wake up. Now I know this is true. ;)

@blchoy
Copy link
Member Author

blchoy commented Jul 16, 2021

A new commit 3bff2a4 was made to handle the remaining documentation issues in #250 and #270.

@blchoy
Copy link
Member Author

blchoy commented Jul 16, 2021

Another commit d06fa3f was made for removing the schematron rule mentioned in #250.

@blchoy
Copy link
Member Author

blchoy commented Jul 16, 2021

Seems to me that most issues relevant to IWXXM 2021-2RC2 have been fixed. The last one could be #271, and it will be done with a new branch FT2021-RC2-refactor. This PR is therefore closed.

@blchoy blchoy closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkorosi jkorosi jkorosi approved these changes

@mgoberfield mgoberfield mgoberfield approved these changes

@amilan17 amilan17 Awaiting requested review from amilan17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blchoy @mgoberfield @jkorosi