Optimize label\shape.py #1460
Closed
Optimize label\shape.py #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PairZhu
force-pushed
the
main
branch
2 times, most recently
from
d5a7002
to
19ca88a
Compare
|
The first CI failure doesn't seem to be caused by my code, can you check the cause? @wkentaro |
|
Reopened in #1471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the rendering logic of shapes so that the thickness of shape lines and crosshair remains consistent on the screen regardless of the zoom level.
Additionally, another advantage is that shapes do not become distorted when the x and y axes have different scaling ratios (this is useful in my project, but such a requirement is uncommon, so the related changes have not been uploaded).