Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Type Description/Hash content (moving to REP-2016) #9

Conversation

emersonknapp
Copy link

Remove contents described in new rep ros-infrastructure#381, pointing to it as a reference for using the features described there.

@emersonknapp emersonknapp changed the title [WIP] Remove REP2016 content (type descriptions/hashes) [WIP] Remove Type Description/Hash content (moving to REP-2016) Jul 11, 2023
@emersonknapp emersonknapp changed the title [WIP] Remove Type Description/Hash content (moving to REP-2016) Remove Type Description/Hash content (moving to REP-2016) Jul 11, 2023

Either way, to facilitate this notice, the ``rmw_event_type_t`` shall be extended to include a new event called ``RMW_EVENT_OFFERED_TYPE_INCOMPATIBLE``.
Related functions and structures will also be updated so that the event can be associated with specific endpoints.

.. TODO::

It's not clear how we will do this just now, since existing "QoS events" lack a way to communicate this information, I (wjwwood) think.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - this event did get implemented so that's why I removed this TODO

@emersonknapp emersonknapp marked this pull request as ready for review July 11, 2023 09:35
@wjwwood wjwwood merged commit a4e1ef5 into wjwwood:evolving_message_types_rep Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants