Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RN 0.48+ warning about requiresMainQueueSetup #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

H-H1RO
Copy link

@H-H1RO H-H1RO commented May 7, 2018

No description provided.

@radex
Copy link
Contributor

radex commented Jun 25, 2018

@artald Can we merge this? The fix looks correct, and as of RN 0.56 the warning pops up in the yellow box instead of just being hidden in the console

@artald
Copy link
Collaborator

artald commented Jun 25, 2018

@radex Even though returning YES for requiresMainQueueSetup is effectively leaving things as they are right now, it’s not really required and we can probably return NO. I don’t want to break things, but still want to look into it. I’ll check it this week.

@radex
Copy link
Contributor

radex commented Jun 25, 2018

Ah! Understood — thank you :)

@radex
Copy link
Contributor

radex commented Jul 25, 2018

@artald Hey! Did you get a chance to look into this? RN 0.56 is shipped and the warnings from this library pop up at every launch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants