Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability to use CocoaPods #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shofman
Copy link

@shofman shofman commented Apr 11, 2018

Adding a podspec allows the user to include this library using

pod 'react-native-keyboard-input', :path => '../node_modules/react-native-keyboard-input'
pod 'react-native-keyboard-tracking-view', :path => '../node_modules/react-native-keyboard-tracking-view'

rather than adding libraries manually.

Dependent on wix-incubator/react-native-keyboard-tracking-view#13 since we need that library to include a podspec

@Ashoat
Copy link

Ashoat commented Apr 24, 2019

@artald, react-native-cli is moving to requiring the use of CocoaPods. Could you take a look at this PR and wix-incubator/react-native-keyboard-tracking-view#13?

@Ashoat
Copy link

Ashoat commented Apr 30, 2019

I've been using these podspecs with the custom patch and noticed there's an issue - the #if __has_include(<KeyboardTrackingView/ObservingInputAccessoryView.h>) line in react-native-keyboard-input resolves as false. The package appears to be named react-native-keyboard-tracking-view rather than KeyboardTrackingView.

@samgermain
Copy link

samgermain commented Apr 11, 2020

Why isn't this on the main page under installing for iOS instead of in a random issue comment

Also it's

pod 'ReactNativeKeyboardInput', :path => '../node_modules/react-native-keyboard-input'
pod 'ReactNativeKeyboardTrackingView', :path => '../node_modules/react-native-keyboard-tracking-view'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants