Make calculate(Horizontal/Vertical)ContentSize
in Component
#276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Complex parent components may need to know how much space their children need before arranging them.
Currently this can be achieved by inflating each child, seeing how much space they take with no restrictions and reinflating them with properly calculated space.
However, this invokes
inflate
on children twice, which may contain expensive calculations, such as rearranging nested child components or calling overriddenapplySizing
, which is useful for caching rendering parameters on custom components.Solution
This can be solved by asking how much space each child needs beforehand, without modifying them.
BaseComponent
already has such functionality withdetermine(Horizontal/Vertical)ContentSize
methods,but they are marked as
protected
and not available in the baseComponent
type.This PR moves said methods to the
Component
interface and updates overridden implementations.