Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema for book metadata #8

Open
wants to merge 3 commits into
base: 1.20.3
Choose a base branch
from

Conversation

solonovamax
Copy link

This is a recreation of #6, because I renamed the branch.

I was unsure where to put these, so I slapped them in the root directory.

I chose the root directory for consistency, as owo-ui.xsd is in the root directory for owo-lib.
If you would like me to place them elsewhere, just let me know and I can do that.

Also, I did not include icon_sprite in the schema, as even though the docs mention it, after looking at the code, it is not a valid property and will just be ignored.

The docs should also be appropriately updated to tell users to include

"$schema": "https://raw.githubusercontent.com/wisp-forest/lavender/1.20.3/lavender-book.json"

at the top of their book's json file,

"$schema": "https://raw.githubusercontent.com/wisp-forest/lavender/1.20.3/lavender-category.json"

in the json metadata for their categories, and

"$schema": "https://raw.githubusercontent.com/wisp-forest/lavender/1.20.3/lavender-entry.json"

in the json metadata for their entries.

I was unsure where to put these so I slapped them in the root directory.
I chose the root directory for consistency, as owo-ui.xsd is in the root directory of owo-lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant