fix: Allow creating empty MLS GroupConversation [WPB-7099] 🍒 #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
type: bug / fix 🐞
👕 size: S
🚨 Potential breaking changes
labels
borichellow
approved these changes
Jul 9, 2024
|
Datadog ReportBranch report: ✅ 0 Failed, 2966 Passed, 105 Skipped, 12.04s Total Time |
MohamadJaara
approved these changes
Jul 9, 2024
borichellow
deleted the
fix/allow_creating_empty_mls_group_conversation-cherry-pick
branch
github-actions bot
added a commit
that referenced
this pull request
Jul 10, 2024
* Commit with unresolved merge conflicts * Fixed cherry-pick issues --------- Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…2872) * Commit with unresolved merge conflicts * Fixed cherry-pick issues --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…2872) * Commit with unresolved merge conflicts * Fixed cherry-pick issues --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
When user trying to create a new MLS GroupConversation only with users that has no KeyPackages, then conversation is not created and error is displayed.
We should allow such a scenario and just create GroupConversation with only 1 (self) user.
Causes (Optional)
Was not implemented (not obvious requirement)
Solutions
Just do it.
In
KeyPackageDataSource.claimKeyPackagesremove checking if all the users were failed (and returningMissingKeyPackagesin that case).So
MLSConversationRepositorywill take care about returning such an error in case when partial MemberList is not allowed.