chore(mls): unify MLSClientIdentity models (WPB-9774) #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchenani
requested review from
borichellow,
MohamadJaara,
yamilmedina and
vitorhugods
mchenani
commented
Jun 18, 2024
| mlsConversationRepository.getMembersIdentities(conversationId, userIds).fold( | ||
| { mapOf() }, | ||
| { | ||
| it.mapValues { (_, identities) -> | ||
| identities.getUserCertificateStatus() | ||
| // todo: we need to check the user name and details! |
There was a problem hiding this comment.
Unfortunately this was missed from the main code; I noticed it here! I don't want to mix the changes for this one in the PR [it's big already] so it's coming in another PR!
8 tasks
mchenani
commented
Jun 18, 2024
...src/commonTest/kotlin/com/wire/kalium/logic/feature/client/ObserveE2EIRequiredUseCaseTest.kt
Outdated
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
mchenani
changed the title
borichellow
approved these changes
Jun 24, 2024
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/ObserveE2EIRequiredUseCase.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/ObserveE2EIRequiredUseCase.kt
Outdated
Show resolved
Hide resolved
vitorhugods
approved these changes
Jun 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/android-cycle-4.6 #2818 +/- ##
============================================================
Coverage ? 58.44%
Complexity ? 7
============================================================
Files ? 1184
Lines ? 46648
Branches ? 4437
============================================================
Hits ? 27264
Misses ? 17406
Partials ? 1978
Continue to review full report in Codecov by Sentry.
|
…p/kalium into fix/unify-mls-client-identity-models
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
…p/kalium into fix/unify-mls-client-identity-models
|
8 tasks
echoes-hq
bot
added
the
echoes: throughput
mchenani
added a commit
that referenced
this pull request
Jul 25, 2024
* chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0)
8 tasks
mchenani
added a commit
that referenced
this pull request
Jul 25, 2024
* chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
* chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
To fetch the MLSClientIdentity from CC we were mapping them in different models, due to different changes we needed more data to be exposed, we needed them to be unified and map all the available data from CC.
Issues
Hard to maintain different models
Due to maturity of CC now we have a rich and solid model we can map full object in Kalium and Android App.
Needs releases with:
With AR
Testing
Test Coverage (Optional)
How to Test
All E2EI features must work as before!
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.