-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PDF 'image' #996
Conversation
@LukeTowers First file is saved. |
@AIC-BV sorry, just so I'm clear, is this a |
It might be 🤭😇 |
I tried to file mode and I don't like it at all, there is no preview and thus you have to open each file/image individually to actually know what it is. This significantly lowers efficiency. It is possible that a client uploads a PDF or IMAGE |
Arguably, a PDF is not an image. It is a file, and yes, we don't have previews of files because it's very likely we can't generate a preview of some file types. |
Its up to you! |
@AIC-BV I do like the way that the Might be worth mocking that up first so we can see how it would look. |
Will continue in #1045 |
See #990
PDF thumb path needs to be provided