Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to external version of Snowboard #980

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

bennothommo
Copy link
Member

@bennothommo bennothommo commented Oct 4, 2023

Changes the underlying Snowboard framework to the one that is provided via NPM in the wintercms/snowboard.js repo.

The only major change was converting the old data config utility calls to the new "Configurable" trait in the Backend widgets. Otherwise, this PR is mainly de-coupling.

@bennothommo bennothommo added maintenance PRs that fix bugs, are translation changes or make only minor changes needs review Issues/PRs that require a review from a maintainer labels Oct 4, 2023
@bennothommo bennothommo added this to the v1.2.4 milestone Oct 4, 2023
@LukeTowers LukeTowers self-requested a review October 6, 2023 02:31
@LukeTowers LukeTowers modified the milestones: v1.2.4, 1.2.5 Dec 27, 2023
@mjauvin
Copy link
Member

mjauvin commented Feb 27, 2024

@bennothommo is this ready to merge?

@bennothommo
Copy link
Member Author

I believe so, but I haven't tested it in a while.

@LukeTowers LukeTowers modified the milestones: 1.2.5, 1.3.0 Mar 1, 2024
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months.
If you intend to continue working on this pull request, please respond within 3 days.
If this pull request is critical for your business, please reach out to us at [email protected].

@github-actions github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Sep 10, 2024
@bennothommo bennothommo removed the stale Issues/PRs that have had no activity and may be archived label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes needs review Issues/PRs that require a review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants