-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Plugin management Composer support #967
base: develop
Are you sure you want to change the base?
Conversation
@jaxwilko re:
I'm wanting to actually implement this in Packager itself. I put in the ground work for a cache system that'll store package details as they are retrieved from the commands, but ultimately, I think in most cases we'll probably have to scrape the Packagist API directly instead of relying on |
Also, might be worth adding those new commands into Packager as well. :) |
@bennothommo yeah I added support for some extra features that i'd like to merge in if they'd be useful for others, sorry for overloading like half of winter/packager btw, it was just easier for prototyping 😂. As for speed and package caching, i ended up writing a composer plugin to do it for us: https://github.com/jaxwilko/composer-winter-plugin the advantage it gives us is that if the user runs either a winter command or a composer command, composer will update the package cache which then lets us detect which plugins come from what packages. The speed issues for show then aren't massively important as we don't need to know them on cold starts and only for info in the backend which should be acceptable :) |
@jaxwilko All good, I figured as much - still would be good to try and put it all in place in Packager once it's finished though. With the Composer plugin, you could probably add your stuff to this repo too: https://github.com/wintercms/package-control. That was the Composer plugin that's going to act as a marketplace gatekeeper. |
This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. |
This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. |
This is very much a WIP, the idea is to fully support plugin management via Composer.
So far I've added the usage to
plugin:list
, see:TODO:
show
commands.\System\Classes\Packager\Composer
as it's currently just overriding theComposer
class provided bywinter/packager
.