-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arbitrary depth of depends on #69
Support arbitrary depth of depends on #69
Conversation
@meesiris thanks for the PR. We're prioritising finishing off 1.1.3 and releasing the website and marketplace. Once these are done, we'll be happy to consider implementing this. We'll be in touch soon. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
@meesiris was there an issue associated with this PR? |
@LukeTowers Please review issues from following link. https://octobercms.com/forum/post/two-level-dependson-function |
@meesiris looks like those issues were fixed by #34 in 712843d. What's the key issue with the original approach in #34 that makes it so that this PR is required? I think I have a grasp of what's going on here but if you could restate the problem as simply as possible that would be helpful and then I should be able to merge this. |
This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. |
This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. |
This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. |
@meesiris (or anyone) did you have a response for #69 (comment)? I'm not opposed to merging this but if no one currently cares then I won't bother at the moment and will just let the bot close it. |
@LukeTowers This PR enhancement of #34 |
@meesiris you didn't respond to my comment. |
@LukeTowers This PR enhancement of #34. It will loop in deep more than #34. |
Depends on with One to Many supported.
Create Plugin, Model and Controller
create_dependencies_table.php
Model: Dependency.php
columns.yaml
fields.yaml
Refresh Plugin for create dependencies table.