-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TagList formwidget #1267
base: develop
Are you sure you want to change the base?
Fix TagList formwidget #1267
Conversation
@bennothommo I just saw you started a PR on TagList as well, thought you might want to review this one. |
@mjauvin it's probably worth adding an example in the Test plugin if there isn't one already, if adding the unit tests becomes too difficult. |
yeah, that's what I'm going to do for now. |
tested working with the following modes using Winter.Test plugin in Post & Record models:
All the above tests also include clearing all values and making sure the model field or relation was updated accordingly. |
@LukeTowers Anything more before merging this? |
@mjauvin @bennothommo Has it been fully tested? |
Yes, see previous comment above. |
The TagList formwidget was not working properly in relation mode if the relation was not using a pivot table (e.g. morphMany/hasMany)
All modes did not update the model field or relation when all tags had been cleared.
Fixes #1223