Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'save' to 'confirm' #1004

Closed
wants to merge 1 commit into from
Closed

Conversation

AIC-BV
Copy link
Contributor

@AIC-BV AIC-BV commented Nov 7, 2023

The uploaded image isn't being saved, but the title and description are added.
This is confusing because it doesn't save/upload the image even though the button says 'save'.

My collegues tought it 'saves' the image as well but their work is gone because they didn't press the actual form submit button. What do you think?

Once the image is actually saved/uploaded, it does edit the title and you don't have to submit the form anymore.
But if the image isn't saved/uploaded, adding the title/description does NOT save/upload the image, which is why I think the button shouldn't be labeled 'save' (or it should save/upload the image)

The uploaded image isn't being saved, but the title and description are added. This is confusing because it doesn't save/upload the image. What do you think?
@AIC-BV AIC-BV marked this pull request as draft November 7, 2023 11:31
@LukeTowers
Copy link
Member

@AIC-BV the form button does "save" the image, the image is uploaded when it is selected and a record for it exists in the database. What is actually not being "saved" is the relationship between the uploaded file and the current record being edited. If you would like for that to happen as soon as the image is uploaded because that works better for your workflow / users, then simply set attachOnUpload: true on the fileupload field configuration: https://wintercms.com/docs/v1.2/docs/backend/forms#file-upload.

Note that this still won't help if the parent record hasn't been created yet.

@AIC-BV
Copy link
Contributor Author

AIC-BV commented Nov 10, 2023

Thank you @LukeTowers sounds like exactly what we require!
Should've read the docs better 🤪

@AIC-BV AIC-BV closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants