RFC: Add recognize_till
#541
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a variant of `repeat_till` that recognizes the repeated portion of the input instead of accumulating it. See: [“Recognizing `repeat_till0` to `()` without the suffix”][1] [1]: winnow-rs#336 (reply in thread)
9999years
force-pushed
the
recognize-till
branch
from
cca6ab3
to
957f667
Compare
Pull Request Test Coverage Report for Build 9523540454Details
💛 - Coveralls |
9999years
added a commit
to MercuryTechnologies/ghciwatch
that referenced
this pull request
Jun 21, 2024
9999years
added a commit
to MercuryTechnologies/ghciwatch
that referenced
this pull request
Jun 21, 2024
9999years
added a commit
to MercuryTechnologies/ghciwatch
that referenced
this pull request
Jun 21, 2024
|
Moved to draft as I take a fairly strict policy to close (or move to draft) PRs that have not formerly been accepted
|
9999years
added a commit
to MercuryTechnologies/ghciwatch
that referenced
this pull request
Jun 21, 2024
|
@epage That's OK by me. Would you like me to open an issue for recognizing the repeated part of a |
|
You are welcome to create an issue from that discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a variant of
repeat_tillthat recognizes the repeated portion of the input instead of accumulating it.See: “Recognizing
repeat_till0to()without the suffix”.I have found this combinator useful in my own code for recognizing ambiguous delimiters.
This code needs to be cleaned up before being merged (we'd probably want a
Rangeargument and an infinite loop check, for example), so consider this a proof of concept. If you're on board with the idea, let me know what the next steps are. Otherwise, feel free to close this PR. Thanks!