-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converter - update UI #86
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
apps/converter/src/components/converter/SmartContractTracker/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - I’ll review the details. For next time if we can make PRs a lot smaller? It’s ok to group multiple items if they are all simple text changes but mixing simple text and conditional logic / functional changes on 1 PR is hard to review and can lead to conflicts.
The PR length will be solved by removing the new pnpm.lock file, I gave her the instructions to fix it ✌️ |
Noted. Initially I grouped these few tasks in one PR as they are simple UI updates. Unexpectedly updated more files as the need to solve hydration error and the pnpm-lock file update. I have removed the changes of pnpm-lock file so the PR length should be shorter now. I will submit smaller PR in the future. Thanks for reviewing it 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes 🎉
@Rieranthony @jasheal @grezle |
SCR-150 remove "Welcome to the Converter" title
SCR-149 display conversion details without wallet connection
SCR-148 remove accept terms screen
fix hydration error for Transaction Panel and Smart Contract Tracker
SCR-136 display toast for getting back to pending conversion screen