Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Des 78 search bar development #157

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Des 78 search bar development #157

merged 4 commits into from
Aug 28, 2023

Conversation

abbylow
Copy link
Contributor

@abbylow abbylow commented Aug 24, 2023

No description provided.

@abbylow abbylow requested a review from grezle August 24, 2023 04:03
@abbylow abbylow requested a review from jasheal as a code owner August 24, 2023 04:03
@linear
Copy link

linear bot commented Aug 24, 2023

SCR-297 [Search Bar] Development

Development Sub-Tasks:

1. Frontend Development:

  1. Setup Search Bar UI: Create the search bar UI component using the finalized designs.
  2. Implement Real-time Filtering: If client-side filtering is chosen, implement real-time filtering as users type.
  3. Handle Various States: Implement different states of the search bar (e.g., empty, typing, results, no results).
    1. When typing the wallet should filter the list in real time
    2. User can search by token name and symbol
  4. Integration with Backend: If server-side searching is necessary, integrate the frontend with the backend API to fetch filtered token lists.
  5. Optimize Performance: Ensure that the search feature is smooth and responsive, especially if dealing with a large list of tokens.
  6. Accessibility Implementation: Make sure the search bar is accessible, including features like keyboard navigation and screen reader compatibility.
  7. "Recent" Feature - is not part of this task, and should be integrated separately

States:

  • Empty:

    image.png

  • Typing: show all tokens that match the inputed words. Example: Typing "USD" should show you "USDT" "USDC"

  • No Results:

    image.png

Design:

https://www.figma.com/file/qSigVM7zUBAfqhqHCXOOpX/Mantle-Core-Style-Guide?type=design&node-id=9507-30944&mode=design&t=GuEYaKxR4acSa6Jr-4

Populated, FAQ open - Mantle-Core-Style-Guide (Figma)

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
mantle-bridge ✅ Ready (Inspect) Visit Preview Aug 24, 2023 4:06am
4 Ignored Deployments
Name Status Preview Updated (UTC)
ethcc ⬜️ Ignored (Inspect) Aug 24, 2023 4:06am
mantle-converter ⬜️ Ignored (Inspect) Aug 24, 2023 4:06am
mantle-faucet ⬜️ Ignored (Inspect) Aug 24, 2023 4:06am
mantle-token-graph ⬜️ Ignored (Inspect) Aug 24, 2023 4:06am

Copy link
Contributor

@grezle grezle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@abbylow abbylow merged commit 209799e into main Aug 28, 2023
7 checks passed
@abbylow abbylow deleted the des-78-search-bar-development branch August 28, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants