Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): resend any missed gas-drops #143

Merged

Conversation

grezle
Copy link
Contributor

@grezle grezle commented Jul 27, 2023

No description provided.

@grezle grezle requested a review from jasheal as a code owner July 27, 2023 21:12
@linear
Copy link

linear bot commented Jul 27, 2023

TSC-303 Supagraph to create a new pending queue for qualifying deposit but gasDropped = null

Why

We received reports from community team regarding qualifying deposit but null MNT bonus sent

What

Upon Graham's investigation -

The logic has us only commit to the gasDrop if the response from the claim check says that one hasnt been made - I suspect these requests are occasionally failing (the controller is set to restart itself if it crashes and I suspect this is the cause). So we need to create a queue on supagraphs side to record the gasDrops and have another sync operation to attempt to clear that queue (by making the check then the gasDrop) - we should only clear it from the queue when we get a valid response from the controller (indicating it has recorded our message)

How

  1. To add a new pending queue on supagraph to record the qualifying deposit but gassDropped = null in the scenario where any part of the system is halted
  2. The pending queue should attempt to clear when the system restarts by checking again with the controller whether the same wallet address has a successful/pending batch airdrop txid per the channel id

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mantle-bridge ✅ Ready (Inspect) Visit Preview Aug 1, 2023 10:39am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ethcc ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 10:39am
mantle-converter ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 10:39am
mantle-faucet ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 10:39am
mantle-token-graph ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 10:39am

@grezle grezle merged commit 34ba73c into main Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant