Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsoid: set s-maxage to 60 seconds #1345

Merged

Conversation

brightbyte
Copy link
Contributor

This sets s-maxage for Parsoid to 60 seconds. If we can get away with this, we can disable active purging (and don't need to implement active purging for the equivalent core endpoints).

Bug: T365630
Change-Id: Ifad202d8f0df5bc383151aa534091e9e16795ffa

@johngian
Copy link
Collaborator

Ideally this should have been a config entry managed from scap deployment repo but since we are almost ready to deprecate i think its fine to have it hardcoded.

@johngian
Copy link
Collaborator

Some tests fail because of the change of the cache header.

@brightbyte
Copy link
Contributor Author

Tests for some old versions of node fail because restbase uses the ?? operator which isn't available until node 14 or so.

Can we stop running tests for node versions oder than 14, and start running tests for node 18 and 20?

@brightbyte
Copy link
Contributor Author

The remaining error is:

  1) Language variants
       should request mobile-sections with no variant and store it:

      AssertionError [ERR_ASSERTION]: Expected: sr; Result: undefined
      + expected - actual

      -false
      +true

This test passes for me. Also, it uses an unrelated endpoint (mobile-html).

Not sure how to procede... @johngian do you have an idea what might be going on here?

This sets s-maxage for Parsoid to 60 seconds. If we can get away with
this, we can disable active purging (and don't need to implement active
purging for the equivalent core endpoints).

Bug: T365630
Change-Id: Ifad202d8f0df5bc383151aa534091e9e16795ffa
@johngian johngian force-pushed the T365630_cache_parsoid_one_minute branch from b36daaa to 1bc43cc Compare June 11, 2024 16:16
* Disable MCS related failures
* Pin jsonc-parser to older version
@johngian johngian force-pushed the T365630_cache_parsoid_one_minute branch from 1bc43cc to 3e496a3 Compare June 11, 2024 16:24
@johngian
Copy link
Collaborator

johngian commented Jun 11, 2024

@brightbyte CI should be passing now. I pinned a dependency to an old version only for dev purposes just for the tests to pass. Also MCS is not supposed to be used. I think its safe to disable the related failures.

@johngian johngian merged commit bb97750 into wikimedia:master Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants