Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to https://github.com/coq/coq/pull/19530 #372

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Sep 17, 2024

Adapt to coq/coq#19530
This should be backward compatible and can be merged at your convenience, before the upstream PR.

@proux01 proux01 mentioned this pull request Sep 17, 2024
43 tasks
@proux01
Copy link
Contributor Author

proux01 commented Sep 17, 2024

Well, ok it's backward compatible but maybe not down to 8.4 !

@proux01
Copy link
Contributor Author

proux01 commented Sep 17, 2024

@whonore what do you want to do with this? (FWIW, I tested it successfully on 8.12 and don't have anything older at hand to know exactly when it breaks)

@whonore
Copy link
Owner

whonore commented Sep 17, 2024

Thanks for the fix.

@whonore whonore merged commit a582fba into whonore:main Sep 17, 2024
19 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Sep 17, 2024

Ha, indeed that works, thanks

@proux01 proux01 deleted the stdlib_repo branch September 17, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants