Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
prantogg committed Jul 3, 2024
1 parent 429059c commit 769d67f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 21 deletions.
22 changes: 2 additions & 20 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Build and Upload JAR
on:
push:
branches:
- master
- main
paths:
- 'src/**'
- 'build.gradle'
Expand All @@ -16,10 +16,6 @@ on:
- 'build.gradle'
- '.github/workflows/main.yml'

env:
GRADLE_OPTS: -Dorg.gradle.daemon=false
DO_NOT_TRACK: true

permissions:
contents: read

Expand All @@ -40,9 +36,6 @@ jobs:
- name: Verify Gradle installation
run: ./gradlew --version

- name: List initial directory contents
run: ls -R

- name: Cache Gradle packages
uses: actions/cache@v3
with:
Expand All @@ -51,23 +44,12 @@ jobs:
restore-keys: |
${{ runner.os }}-gradle-
- name: Make gradlew executable
run: chmod +x ./gradlew

- name: Run build
run: ./gradlew build shadowJar
run: chmod +x ./gradlew && ./gradlew build shadowJar
env:
GRADLE_OPTS: -Dorg.gradle.daemon=false
DO_NOT_TRACK: true

- name: List files in project directory
run: ls -R
shell: bash

- name: List files in build directory
run: ls -R lib/build
shell: bash

- name: Upload build artifacts
uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion lib/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ java {
tasks.named('jar') {
manifest {
attributes('Implementation-Title': project.name,
'Implementation-Version': project.version)
'Implementation-Version': project.version)
}
}

Expand Down

0 comments on commit 769d67f

Please sign in to comment.