Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for draft-6 examples #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sixlive
Copy link

@sixlive sixlive commented Feb 15, 2019

Description

This adds support for draft-6 examples. Since OpenAPI only supports single examples this transform takes the first example from the array of examples and sets that as the value. I've been using my implementation with speccy for a few days and its been working great and is a must have for my workflow.

Resolves #20

index.js Outdated Show resolved Hide resolved
@Solosneros
Copy link

@sixlive @philsturgeon Hey, looking forward to that PR. Is there anything I can do to help? :)

@sixlive
Copy link
Author

sixlive commented Mar 4, 2019

Is there any way we can get an update on this?

@XVincentX
Copy link

@philsturgeon Can we merge and release this? I could use it in Prism.

@philsturgeon
Copy link
Contributor

@XVincentX I don't work at WeWork anymore. I work at stoplight.io, with you!

@djtarazona hey there! Do you know who is looking after this? If it's nobody can you ask some higher up to make me a collaborator or give me the package? It's a shame to see this getting ignored.

@XVincentX
Copy link

I thought you were still a collaborator with privileges!

philsturgeon
philsturgeon previously approved these changes Jun 13, 2019
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve but I think I'm a random person.

XVincentX
XVincentX previously approved these changes Jun 13, 2019
index.js Outdated Show resolved Hide resolved
@djtarazona
Copy link

@djtarazona hey there! Do you know who is looking after this? If it's nobody can you ask some higher up to make me a collaborator or give me the package? It's a shame to see this getting ignored.

I don't know who's looking after this. @iainmcgin can you help out here?

@philsturgeon
Copy link
Contributor

I would be very happy to take this over btw, and keep it maintained for as long as it’s required. I’m working on closing the OpenAPI and JSON Schema divergence gap through a few different means with the two projects themselves but until then this tool is really important, and shouldn’t be left to stagnate. I know Pascal said he’d have to check with the lawyers before giving code away, so if we could get the ball moving on that that’d be great! :)

@mribichich
Copy link

could this be merge or is no longer maintained?

@sixlive sixlive dismissed stale reviews from XVincentX and philsturgeon via 441c117 July 11, 2019 16:07
@philsturgeon
Copy link
Contributor

Not being maintained at all, see https://github.com/openapi-contrib/json-schema-to-openapi-schema instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to support examples from draft-06
6 participants