Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wider copy to clipboard area #9450

Merged
merged 11 commits into from
Dec 18, 2024
Merged

Conversation

Ryosei-Fukushima
Copy link
Contributor

@Ryosei-Fukushima Ryosei-Fukushima commented Nov 28, 2024

https://redmine.weseek.co.jp/issues/157769
ページのタイトルにカーソルを合わせた時、カーソルが少しでもずれるとクリップボードが出てこなくなってしまっていた。

修正点
display: none;ではなく、visibility: hidden;を使うことで要素がなくなる問題を解決。

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: a426019

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

setIsHovered(false);
}, 1000);
setHideTimeout(timeout);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この解決策は大仰すぎるし複雑です。別の解決策を提示してください。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この部分を削除し、わかりやすく簡素にしました。
ボタン分のヒットエリアを広げました。

@yuki-takei yuki-takei changed the title fix: Wider-clipboard-area fix: Wider copy to clipboard area Dec 18, 2024
mergify bot added a commit that referenced this pull request Dec 18, 2024
@mergify mergify bot merged commit 87c2f34 into master Dec 18, 2024
26 checks passed
@mergify mergify bot deleted the fix/157769-Wider-clipboard-area branch December 18, 2024 10:08
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants