Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imprv: Security settings screen redesign #9137

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

imprv: Security settings screen redesign #9137

wants to merge 50 commits into from
+125 −70

Conversation

kazutoweseek
Copy link
Contributor

@kazutoweseek kazutoweseek commented Sep 18, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 433fee7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

miya
miya requested changes Oct 8, 2024
View reviewed changes
apps/app/src/client/components/Admin/Security/SecuritySetting.jsx Outdated Show resolved Hide resolved
apps/app/src/client/components/Admin/Security/SecuritySetting.jsx Outdated Show resolved Hide resolved
apps/app/src/client/components/Admin/Security/SecuritySetting.jsx Outdated
<div className="dropdown">
<button
className={`btn btn-outline-secondary dropdown-toggle text-end col-12
col-md-auto ${adminGeneralSecurityContainer.switchIsShowRestrictedByOwner}`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここにメソッドを渡しているのはなぜ？ switchIsShowRestrictedByOwner というメソッド自体不要なら AdminGeneralSecurityContainer から削除してください。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switchIsShowRestrictedByOwner を使わないなら削除してください

miya
miya requested changes Oct 17, 2024
View reviewed changes
apps/app/src/client/components/Admin/Security/SecuritySetting.jsx
</table>
</div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 「自分のみ」「特定グループのみ」でほぼ同じ構造の要素なのでこの dropdown は共通化できそう
  • renderPageDeletePermission() などを参考に

@miya miya requested a review from yuki-takei October 17, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miya miya miya requested changes

@yuki-takei yuki-takei Awaiting requested review from yuki-takei

Assignees
No one assigned
Labels
type/improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazutoweseek @miya