feature: addin retry in close rooms with delay between attempts (#405)

* feature: adding retry in close rooms with delay between attempts

chats/apps/api/v1/rooms/viewsets.py

@@ -1,6 +1,8 @@
+import time
 from datetime import timedelta
 
 from django.conf import settings
+from django.db import DatabaseError, transaction
 from django.db.models import BooleanField, Case, Count, Max, OuterRef, Q, Subquery, When
 from django.utils import timezone
 from django_filters.rest_framework import DjangoFilterBackend
@@ -149,17 +151,31 @@ def close(
         # Add send room notification to the channels group
         instance = self.get_object()
 
-        tags = request.data.get("tags", None)
-        instance.close(tags, "agent")
-        serialized_data = RoomSerializer(instance=instance)
-        instance.notify_queue("close", callback=True)
-        instance.notify_user("close")
-
-        if not settings.ACTIVATE_CALC_METRICS:
-            return Response(serialized_data.data, status=status.HTTP_200_OK)
-
-        close_room(str(instance.pk))
-        return Response(serialized_data.data, status=status.HTTP_200_OK)
+        for attempt in range(settings.MAX_RETRIES):
+            try:
+                with transaction.atomic():
+                    tags = request.data.get("tags", None)
+                    instance.close(tags, "agent")
+                    serialized_data = RoomSerializer(instance=instance)
+                    instance.notify_queue("close", callback=True)
+                    instance.notify_user("close")
+
+                    if not settings.ACTIVATE_CALC_METRICS:
+                        return Response(serialized_data.data, status=status.HTTP_200_OK)
+
+                    close_room(str(instance.pk))
+                    return Response(serialized_data.data, status=status.HTTP_200_OK)
+
+            except DatabaseError as error:
+                if attempt < settings.MAX_RETRIES - 1:
+                    delay = settings.RETRY_DELAY_SECONDS * (2**attempt)
+                    time.sleep(delay)
+                    continue
+                else:
+                    return Response(
+                        {"error": f"Transaction failed after retries: {str(error)}"},
+                        status=status.HTTP_500_INTERNAL_SERVER_ERROR,
+                    )
 
     def perform_create(self, serializer):
         serializer.save()

chats/apps/rooms/models.py

@@ -7,6 +7,7 @@
 from django.db import models
 from django.utils import timezone
 from django.utils.translation import gettext_lazy as _
+from requests.exceptions import RequestException
 from rest_framework.exceptions import ValidationError
 
 from chats.core.models import BaseModel
@@ -179,16 +180,23 @@ def request_callback(self, room_data: dict):
         if self.callback_url is None:
             return None
 
-        requests.post(
-            self.callback_url,
-            data=json.dumps(
-                {"type": "room.update", "content": room_data},
-                sort_keys=True,
-                indent=1,
-                cls=DjangoJSONEncoder,
-            ),
-            headers={"content-type": "application/json"},
-        )
+        try:
+            response = requests.post(
+                self.callback_url,
+                data=json.dumps(
+                    {"type": "room.update", "content": room_data},
+                    sort_keys=True,
+                    indent=1,
+                    cls=DjangoJSONEncoder,
+                ),
+                headers={"content-type": "application/json"},
+            )
+            response.raise_for_status()
+
+        except RequestException as error:
+            raise RuntimeError(
+                f"Failed to send callback to {self.callback_url}: {str(error)}"
+            )
 
     def base_notification(self, content, action):
         if self.user:

chats/settings.py

@@ -418,3 +418,7 @@
 
 WS_MESSAGE_RETRIES = env.int("WS_MESSAGE_RETRIES", default=5)
 WEBSOCKET_RETRY_SLEEP = env.int("WEBSOCKET_RETRY_SLEEP", default=0.5)
+
+# CLOSE ROOM RETRY
+MAX_RETRIES = env.int("WS_MESSAGE_RETRIES", default=3)
+RETRY_DELAY_SECONDS = env.int("WS_MESSAGE_RETRIES", default=0.5)