Skip to content

Commit

Permalink
Revert "pml/cm: fix buffer usage in MCA_PML_CM_HVY_SEND_REQUEST_BSEND…
Browse files Browse the repository at this point in the history
…_ALLOC()"

This reverts commit d71fe93.

The revert fixes a bug revealed by mtt ibm test suite. The send buffer
instead of the attached user buffer was not used for MPI_Bsend.

This violates the MPI_Bsend semantic and makes it unsafe to reuse the
send buffer after the function returns.

The revert is also needed for 4.x

Signed-off-by: Wenduo Wang <[email protected]>
  • Loading branch information
wenduwan committed Sep 3, 2023
1 parent 76b91ce commit bfe6771
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ompi/mca/pml/cm/pml_cm_sendreq.h
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ do { \
&max_data ); \
opal_convertor_prepare_for_send( &sendreq->req_send.req_base.req_convertor, \
&(ompi_mpi_packed.dt.super), \
max_data, sendreq->req_addr ); \
max_data, sendreq->req_buff ); \
} \
} \
} while(0);
Expand Down

0 comments on commit bfe6771

Please sign in to comment.