Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix docker pushes #91

Merged
merged 8 commits into from
Aug 13, 2024
Merged

CI: fix docker pushes #91

merged 8 commits into from
Aug 13, 2024

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jun 11, 2024

Fixes #41

ref image
PR - (just test)
master wemakeservices/caddy-gen:master, ghcr.io/wemake-services/caddy-gen:master
tag M.m.p wemakeservices/caddy-gen:M.m.p, wemakeservices/caddy-gen:latest, ghcr.io/wemake-services/caddy-gen:M.m.p, ghcr.io/wemake-services/caddy-gen:latest

@casperdcl
Copy link
Contributor Author

casperdcl commented Jun 11, 2024

@sobolevn this is ready for merge now. It'll push to ghcr.io/wemake-services/caddy-gen.

If you want to push to wemakeservices/caddy-gen too, then you'll have to add DOCKER_USER and DOCKER_PASS env vars to https://github.com/wemake-services/caddy-gen/settings/secrets/actions

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can copy release workflow from https://github.com/wemake-services/kira-review

@casperdcl casperdcl changed the title CI: docker push to ghcr.io CI: fix docker pushes Jun 11, 2024
@casperdcl
Copy link
Contributor Author

done ;)

@casperdcl
Copy link
Contributor Author

ping :)

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the notification

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@sobolevn sobolevn merged commit 1b1d9b9 into wemake-services:master Aug 13, 2024
1 check passed
@sobolevn
Copy link
Member

Thank you!

casperdcl added a commit to SyneRBI/PETRIC-backend that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Docker version tags
2 participants