Merge pull request #2607 from wellcomecollection/rules-for-requesting…

…-0424 Enable requesting for somja (rules for requesting update)
wellcomecollection · Apr 12, 2024 · 4fc52f7 · 4fc52f7
2 parents a9cb907 + ebf8921
commit 4fc52f7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...el/src/main/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequesting.scala b/...el/src/main/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequesting.scala
@@ -35,7 +35,8 @@ import weco.sierra.models.data.SierraItemData
   *     https://documentation.iii.com/sierrahelp/Content/sril/sril_records_varfld_types_item.html
   *
   * This was last checked against Sierra based on a set of rules provided by
-  * Natalie Pollecutt on 8th February 2024
+  * Louise Simon on 20th March 2024
+  * https://wellcome.slack.com/archives/C3TQSF63C/p1710937847843969
   */
 object SierraRulesForRequesting {
   def apply(itemData: SierraItemData): RulesForRequestingResult =
@@ -279,7 +280,6 @@ object SierraRulesForRequesting {
       //    v|i||79||=|sgmoh||
       //    v|i||79||=|somet||
       //    v|i||79||=|somge||
-      //    v|i||79||=|somja||
       //    v|i||79||=|sompr||
       //    q|i||79||=|somsy||Please complete a manual request slip.  This item cannot be requested online.
       //
@@ -302,7 +302,6 @@ object SierraRulesForRequesting {
               "sgmoh",
               "somet",
               "somge",
-              "somja",
               "sompr",
               "somsy"
             ) =>

diff --git a/...rc/test/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequestingTest.scala b/...rc/test/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequestingTest.scala
@@ -175,7 +175,6 @@ class SierraRulesForRequestingTest
         "sgmoh",
         "somet",
         "somge",
-        "somja",
         "sompr",
         "somsy")