Use withManager
#196
Merged
Use withManager
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FinleyMcIlwaine I'm not seeing the uncaught exceptions anymore on this branch, do you? I thought when we tried this locally on your machine we were still seeing them, but I don't see them locally (tried with 9.2, 9.8 and 9.10). If you're also not seeing them, I guess we can close #156? |
edsko
force-pushed
the
edsko/issue190
branch
2 times, most recently
from
12a267f
to
4c53f55
Compare
This depends on kazu-yamamoto/http2#137. Closes #190.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on kazu-yamamoto/http2#137.
Closes #190.