You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Q1: Go does not allow const of the same name and different types in the same package; so I changed the name of the constant, which may differ from the community specification, I wonder if it is appropriate?
I understand the naming style is different between the language specifications.
From TypeScript to Go means, we have to change some of our naming specifications so that the code can fit the Go styles.
My opinion is: we should follow the style from TS Wechaty as our default, and only change it when there's a must.
For the Go Lang, I believe we can follow another official style which will be a perfect match: @chatie/grpc (Wechaty has dependency to this module)
I believe #9 has plenty of examples related to this discussion.
@dingdayu Could you please have a look at that PR and make some comments?
And also I'd like to invite you to make a code review for that PR, make a Request changes or Approve it so that we can get an alignment together with @SilkageNet
Questions from WIP: add user/message.go #4
Q1
I understand the naming style is different between the language specifications.
From TypeScript to Go means, we have to change some of our naming specifications so that the code can fit the Go styles.
My opinion is: we should follow the style from TS Wechaty as our default, and only change it when there's a must.
For the Go Lang, I believe we can follow another official style which will be a perfect match: @chatie/grpc (Wechaty has dependency to this module)
You can find the
Image
definition here:https://github.com/Chatie/grpc/blob/ab85b7345b90c167a031710b9a819f9220c09002/proto/wechaty/puppet/message.proto#L25-L30
Which means in Go, we can align to:
The text was updated successfully, but these errors were encountered: