Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MiniProgram #10

Merged
merged 2 commits into from
Apr 3, 2020
Merged

add MiniProgram #10

merged 2 commits into from
Apr 3, 2020

Conversation

dchaofei
Copy link
Collaborator

@dchaofei dchaofei commented Apr 3, 2020

No description provided.

Signed-off-by: dchaofei <[email protected]>
@huan huan requested review from dingdayu and SilkageNet April 3, 2020 07:47
@huan
Copy link
Member

huan commented Apr 3, 2020

Thank you for your translation, your code looks great!

I'd like to invite @SilkageNet and @dingdayu to have a look at this PR and give some comments.

And we are right talking about the naming styles for Go Wechaty, you can have a look from here: #6

Appreciate it!

Copy link
Contributor

@SilkageNet SilkageNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit 5299705 into wechaty:master Apr 3, 2020
@huan
Copy link
Member

huan commented Apr 3, 2020

@dchaofei Thank you very much for your MiniProgram class, the code is great and this is an one more step for translating the TS Wechaty to our Go Wechaty, Cheers!

@SilkageNet Thank you for approving this PR too after we have @dchaofei onboard, I believe that the Go Wechaty project will be able to move faster.

@huan
Copy link
Member

huan commented Apr 3, 2020

@dchaofei I have sent a GitHub team invitation to you for joining our Wechaty Org and be a member of our @wechaty/contributors team. Please check and accept it, thank you very much!

You've invited Chao Fei to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants